Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mermaid graph style #559

Conversation

sulmar
Copy link
Contributor

@sulmar sulmar commented Dec 20, 2023

No description provided.

@sulmar sulmar marked this pull request as draft December 20, 2023 15:23
@sulmar sulmar marked this pull request as ready for review December 20, 2023 15:23
@mclift mclift mentioned this pull request Jun 20, 2024
@mclift mclift changed the base branch from dev to feature/add-mermaid-graph-style June 20, 2024 19:06
@mclift mclift merged commit d6131a6 into dotnet-state-machine:feature/add-mermaid-graph-style Jun 20, 2024
1 check failed
@mclift
Copy link
Member

mclift commented Jun 20, 2024

@sulmar Thanks for starting the work on this. I'll follow up soon with a PR to make it more complete, but please let me know if you're already working on it.

@sulmar
Copy link
Contributor Author

sulmar commented Jun 21, 2024

@mclift Yes, before I asked you for refactoring, I created an independent project: https://github.com/sulmar/stateless-mermaid
I would now like to move this solution to your library. Please let me know when is the best time to do this.

@mclift
Copy link
Member

mclift commented Jun 21, 2024

The code in sulmar/stateless-mermaid seems very close to the changes in your pull request. Would you mind if I built on your work to improve feature parity with the Graphviz style and add test coverage? I'd do this in the new feature branch and create a PR from there.

@sulmar
Copy link
Contributor Author

sulmar commented Jun 21, 2024

Yes, it is very similar because the pull request was created based on this project. Sure, grab my code. I will be very happy because the stateless library is one of my favorites. I have given many presentations on it. For example on the MS Tech Summit 2022.

I also have another idea, but I'll work on it after your commit.

@mclift
Copy link
Member

mclift commented Jun 21, 2024

That's really cool! Okay, to be continued...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants